Skip to content

Update crawl_google_scholar_citation.py #11655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update crawl_google_scholar_citation.py #11655

wants to merge 2 commits into from

Conversation

AlfianAliM
Copy link

@AlfianAliM AlfianAliM commented Oct 2, 2024 •
edited
Loading

Describe your change:

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing. (Note: I added comments for clarity but did not include new doctests.)
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
    (Example URL: Web Scraping)
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@AlfianAliM AlfianAliM requested a review from cclauss as a code owner October 2, 2024 01:27
@AlfianAliM AlfianAliM marked this pull request as draft October 2, 2024 01:29
@AlfianAliM AlfianAliM marked this pull request as ready for review October 2, 2024 01:30
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 2, 2024
@AlfianAliM
Copy link
Author

Hi @cclauss , I have made some updates in this pull request:

  • Improved code readability by adding comments.

Could you please take a look and let me know your thoughts? Thank you!

@AlfianAliM AlfianAliM closed this Oct 2, 2024
@AlfianAliM AlfianAliM deleted the patch-1 branch October 2, 2024 06:38
@AlfianAliM AlfianAliM restored the patch-1 branch October 2, 2024 06:39
@AlfianAliM AlfianAliM reopened this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlfianAliM